lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 009/346] gpio: pca953x: Fix NBANK calculation for PCA9536
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vignesh R <vigneshr@ti.com>

    commit a246b8198f776a16d1d3a3bbfc2d437bad766b29 upstream.

    NBANK() macro assumes that ngpios is a multiple of 8(BANK_SZ) and
    hence results in 0 banks for PCA9536 which has just 4 gpios. This is
    wrong as PCA9356 has 1 bank with 4 gpios. This results in uninitialized
    PCA953X_INVERT register. Fix this by using DIV_ROUND_UP macro in
    NBANK().

    Signed-off-by: Vignesh R <vigneshr@ti.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/gpio/gpio-pca953x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpio/gpio-pca953x.c
    +++ b/drivers/gpio/gpio-pca953x.c
    @@ -76,7 +76,7 @@ MODULE_DEVICE_TABLE(i2c, pca953x_id);
    #define MAX_BANK 5
    #define BANK_SZ 8

    -#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ)
    +#define NBANK(chip) DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ)

    struct pca953x_chip {
    unsigned gpio_start;
    \
     
     \ /
      Last update: 2016-11-14 05:04    [W:3.278 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site