[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 3.16 067/346] s390/mm: fix gmap tlb flush issues
3.16.39-rc1 review patch.  If anyone has any objections, please let me know.


From: David Hildenbrand <>

commit f045402984404ddc11016358411e445192919047 upstream.

__tlb_flush_asce() should never be used if multiple asce belong to a mm.

As this function changes mm logic determining if local or global tlb
flushes will be neded, we might end up flushing only the gmap asce on all
CPUs and a follow up mm asce flushes will only flush on the local CPU,
although that asce ran on multiple CPUs.

The missing tlb flushes will provoke strange faults in user space and even
low address protections in user space, crashing the kernel.

Fixes: 1b948d6caec4 ("s390/mm,tlb: optimize TLB flushing for zEC12")
Reported-by: Sascha Silbe <>
Acked-by: Martin Schwidefsky <>
Signed-off-by: David Hildenbrand <>
Signed-off-by: Martin Schwidefsky <>
[bwh: Backported to 3.16: adjust filename, context]
Signed-off-by: Ben Hutchings <>
arch/s390/include/asm/tlbflush.h | 3 ++-
arch/s390/mm/pgtable.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)

--- a/arch/s390/include/asm/tlbflush.h
+++ b/arch/s390/include/asm/tlbflush.h
@@ -88,7 +88,8 @@ static inline void __tlb_flush_full(stru

- * Flush TLB entries for a specific ASCE on all CPUs.
+ * Flush TLB entries for a specific ASCE on all CPUs. Should never be used
+ * when more than one asce (e.g. gmap) ran on this mm.
static inline void __tlb_flush_asce(struct mm_struct *mm, unsigned long asce)
--- a/arch/s390/mm/pgtable.c
+++ b/arch/s390/mm/pgtable.c
@@ -202,7 +202,7 @@ static int gmap_unlink_segment(struct gm
static void gmap_flush_tlb(struct gmap *gmap)
- __tlb_flush_asce(gmap->mm, (unsigned long) gmap->table |
+ __tlb_flush_idte((unsigned long) gmap->table |
@@ -221,7 +221,7 @@ void gmap_free(struct gmap *gmap)

/* Flush tlb. */
- __tlb_flush_asce(gmap->mm, (unsigned long) gmap->table |
+ __tlb_flush_idte((unsigned long) gmap->table |
 \ /
  Last update: 2016-11-14 05:02    [W:0.846 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site