lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 105/346] nfs: don't create zero-length requests
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Benjamin Coddington <bcodding@redhat.com>

    commit 149a4fddd0a72d526abbeac0c8deaab03559836a upstream.

    NFS doesn't expect requests with wb_bytes set to zero and may make
    unexpected decisions about how to handle that request at the page IO layer.
    Skip request creation if we won't have any wb_bytes in the request.

    Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
    Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
    Reviewed-by: Weston Andros Adamson <dros@primarydata.com>
    Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/nfs/write.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/fs/nfs/write.c
    +++ b/fs/nfs/write.c
    @@ -1222,6 +1222,9 @@ int nfs_updatepage(struct file *file, st
    dprintk("NFS: nfs_updatepage(%pD2 %d@%lld)\n",
    file, count, (long long)(page_file_offset(page) + offset));

    + if (!count)
    + goto out;
    +
    if (nfs_can_extend_write(file, page, inode)) {
    count = max(count + offset, nfs_page_length(page));
    offset = 0;
    @@ -1232,7 +1235,7 @@ int nfs_updatepage(struct file *file, st
    nfs_set_pageerror(page);
    else
    __set_page_dirty_nobuffers(page);
    -
    +out:
    dprintk("NFS: nfs_updatepage returns %d (isize %lld)\n",
    status, (long long)i_size_read(inode));
    return status;
    \
     
     \ /
      Last update: 2016-11-14 04:57    [W:4.029 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site