lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 019/346] drm/radeon: Don't leak runtime pm ref on driver unload
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Lukas Wunner <lukas@wunner.de>

    commit 19de659cb7216eb1c04889bd1a248593f296e19f upstream.

    radeon_driver_load_kms() calls pm_runtime_put_autosuspend() if
    radeon_is_px(dev), but radeon_driver_unload_kms() calls
    pm_runtime_get_sync() unconditionally. We therefore leak a runtime pm
    ref whenever radeon is unloaded on a non-PX machine or if runpm=0. The
    GPU will subsequently never runtime suspend after loading radeon again.

    Fix by taking the runtime pm ref under the same condition that it was
    released on driver load.

    Fixes: 10ebc0bc0934 ("drm/radeon: add runtime PM support (v2)")
    Cc: Dave Airlie <airlied@redhat.com>
    Cc: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Lukas Wunner <lukas@wunner.de>
    Acked-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link: http://patchwork.freedesktop.org/patch/msgid/aaf71106c042126817aeca8b8e54ed468ab61ef7.1465392124.git.lukas@wunner.de
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/gpu/drm/radeon/radeon_kms.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/gpu/drm/radeon/radeon_kms.c
    +++ b/drivers/gpu/drm/radeon/radeon_kms.c
    @@ -61,7 +61,9 @@ int radeon_driver_unload_kms(struct drm_
    if (rdev->rmmio == NULL)
    goto done_free;

    - pm_runtime_get_sync(dev->dev);
    + if (radeon_is_px(dev)) {
    + pm_runtime_get_sync(dev->dev);
    + }

    radeon_acpi_fini(rdev);

    \
     
     \ /
      Last update: 2016-11-14 04:42    [W:2.944 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site