lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 344/346] compiler-gcc: disable -ftracer for __noclone functions
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Paolo Bonzini <pbonzini@redhat.com>

    commit 95272c29378ee7dc15f43fa2758cb28a5913a06d upstream.

    -ftracer can duplicate asm blocks causing compilation to fail in
    noclone functions. For example, KVM declares a global variable
    in an asm like

    asm("2: ... \n
    .pushsection data \n
    .global vmx_return \n
    vmx_return: .long 2b");

    and -ftracer causes a double declaration.

    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Michal Marek <mmarek@suse.cz>
    Cc: kvm@vger.kernel.org
    Reported-by: Linda Walsh <lkml@tlinx.org>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Cc: Philip Müller <philm@manjaro.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    include/linux/compiler-gcc.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/linux/compiler-gcc.h
    +++ b/include/linux/compiler-gcc.h
    @@ -177,7 +177,7 @@
    #define unreachable() __builtin_unreachable()

    /* Mark a function definition as prohibited from being cloned. */
    -#define __noclone __attribute__((__noclone__))
    +#define __noclone __attribute__((__noclone__, __optimize__("no-tracer")))

    #endif /* GCC_VERSION >= 40500 */

    \
     
     \ /
      Last update: 2016-11-14 04:40    [W:4.713 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site