[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 3.16 223/346] clocksource/drivers/sun4i: Clear interrupts after stopping timer in probe function
3.16.39-rc1 review patch.  If anyone has any objections, please let me know.


From: Chen-Yu Tsai <>

commit b53e7d000d9e6e9fd2c6eb6b82d2783c67fd599e upstream.

The bootloader (U-boot) sometimes uses this timer for various delays.
It uses it as a ongoing counter, and does comparisons on the current
counter value. The timer counter is never stopped.

In some cases when the user interacts with the bootloader, or lets
it idle for some time before loading Linux, the timer may expire,
and an interrupt will be pending. This results in an unexpected
interrupt when the timer interrupt is enabled by the kernel, at
which point the event_handler isn't set yet. This results in a NULL
pointer dereference exception, panic, and no way to reboot.

Clear any pending interrupts after we stop the timer in the probe
function to avoid this.

Signed-off-by: Chen-Yu Tsai <>
Signed-off-by: Daniel Lezcano <>
Acked-by: Maxime Ripard <>
Signed-off-by: Ben Hutchings <>
drivers/clocksource/sun4i_timer.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

--- a/drivers/clocksource/sun4i_timer.c
+++ b/drivers/clocksource/sun4i_timer.c
@@ -120,12 +120,16 @@ static struct clock_event_device sun4i_c
.set_next_event = sun4i_clkevt_next_event,

+static void sun4i_timer_clear_interrupt(void)
+ writel(TIMER_IRQ_EN(0), timer_base + TIMER_IRQ_ST_REG);

static irqreturn_t sun4i_timer_interrupt(int irq, void *dev_id)
struct clock_event_device *evt = (struct clock_event_device *)dev_id;

- writel(0x1, timer_base + TIMER_IRQ_ST_REG);
+ sun4i_timer_clear_interrupt();

@@ -182,6 +186,9 @@ static void __init sun4i_timer_init(stru
/* Make sure timer is stopped before playing with interrupts */

+ /* clear timer0 interrupt */
+ sun4i_timer_clear_interrupt();
sun4i_clockevent.cpumask = cpu_possible_mask;
sun4i_clockevent.irq = irq;

 \ /
  Last update: 2016-11-14 04:39    [W:0.703 / U:1.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site