lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 198/346] Input: i8042 - set up shared ps2_cmd_mutex for AUX ports
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dmitry Torokhov <dmitry.torokhov@gmail.com>

    commit 47af45d684b5f3ae000ad448db02ce4f13f73273 upstream.

    The commit 4097461897df ("Input: i8042 - break load dependency ...")
    correctly set up ps2_cmd_mutex pointer for the KBD port but forgot to do
    the same for AUX port(s), which results in communication on KBD and AUX
    ports to clash with each other.

    Fixes: 4097461897df ("Input: i8042 - break load dependency ...")
    Reported-by: Bruno Wolff III <bruno@wolff.to>
    Tested-by: Bruno Wolff III <bruno@wolff.to>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/input/serio/i8042.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/input/serio/i8042.c
    +++ b/drivers/input/serio/i8042.c
    @@ -1258,6 +1258,7 @@ static int __init i8042_create_aux_port(
    serio->write = i8042_aux_write;
    serio->start = i8042_start;
    serio->stop = i8042_stop;
    + serio->ps2_cmd_mutex = &i8042_mutex;
    serio->port_data = port;
    serio->dev.parent = &i8042_platform_device->dev;
    if (idx < 0) {
    \
     
     \ /
      Last update: 2016-11-14 03:47    [W:6.645 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site