lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 233/346] NFSv4.x: Fix a refcount leak in nfs_callback_up_net
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Trond Myklebust <trond.myklebust@primarydata.com>

    commit 98b0f80c2396224bbbed81792b526e6c72ba9efa upstream.

    On error, the callers expect us to return without bumping
    nn->cb_users[].

    Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/nfs/callback.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/nfs/callback.c
    +++ b/fs/nfs/callback.c
    @@ -301,6 +301,7 @@ static int nfs_callback_up_net(int minor
    err_socks:
    svc_rpcb_cleanup(serv, net);
    err_bind:
    + nn->cb_users[minorversion]--;
    dprintk("NFS: Couldn't create callback socket: err = %d; "
    "net = %p\n", ret, net);
    return ret;
    \
     
     \ /
      Last update: 2016-11-14 03:37    [W:2.317 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site