lkml.org 
[lkml]   [2016]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show max page count
Date
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Thursday, November 10, 2016 11:09 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; Stephen Hemminger
> <sthemmin@microsoft.com>; Alex Ng (LIS) <alexng@microsoft.com>; Alex
> Ng (LIS) <alexng@microsoft.com>
> Subject: Re: [PATCH V2 08/14] Drivers: hv: balloon: Fix info request to show
> max page count
>
> On Tue, Nov 01, 2016 at 01:07:28PM -0700, kys@exchange.microsoft.com
> wrote:
> > From: Alex Ng <alexng@messages.microsoft.com>
> >
> > Balloon driver was only printing the size of the info blob and not the
> > actual content. This fixes it so that the info blob (max page count as
> > configured in Hyper-V) is printed out.
> >
> > Signed-off-by: Alex Ng <alexng@microsoft.com>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> > drivers/hv/hv_balloon.c | 9 +++++++--
> > 1 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
> > index 8cac29a..14c3dc4 100644
> > --- a/drivers/hv/hv_balloon.c
> > +++ b/drivers/hv/hv_balloon.c
> > @@ -1034,8 +1034,13 @@ static void process_info(struct
> hv_dynmem_device *dm, struct dm_info_msg *msg)
> >
> > switch (info_hdr->type) {
> > case INFO_TYPE_MAX_PAGE_CNT:
> > - pr_info("Received INFO_TYPE_MAX_PAGE_CNT\n");
> > - pr_info("Data Size is %d\n", info_hdr->data_size);
> > + if (info_hdr->data_size == sizeof(__u64)) {
> > + __u64 *max_page_count = (__u64 *)&info_hdr[1];
>
> Why __u64 instead of u64? Is this code shared with user space?

__u64 was being used in other parts of this code already and I decided to follow that.

I wasn't aware of this distinction between the two.
This code is not shared in user-space, so perhaps we should clean up this file in a future patch.

Thanks for bringing it up.

>
> regards,
> dan carpenter
>

\
 
 \ /
  Last update: 2016-11-11 00:18    [W:0.086 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site