Messages in this thread |  | | From | Vivien Didelot <> | Subject | Re: [PATCH net-next 04/11] net: dsa: mv88e6xxx: add port FID accessors | Date | Wed, 02 Nov 2016 02:01:20 +0100 |
| |
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
>> --- a/drivers/net/dsa/mv88e6xxx/port.c >> +++ b/drivers/net/dsa/mv88e6xxx/port.c >> @@ -61,6 +61,8 @@ int mv88e6xxx_port_set_state(struct mv88e6xxx_chip *chip, int port, u8 state) >> return 0; >> } >> >> +/* Offset 0x05: Port Control 1 */ >> + >> /* Offset 0x06: Port Based VLAN Map */ >> >> int mv88e6xxx_port_set_vlan_map(struct mv88e6xxx_chip *chip, int port, u16 map) > > This comment seems in an odd place.
It isn't. Port's default FID uses register 0x05 and I document them above the related functions.
Thanks,
Vivien
|  |