Messages in this thread |  | | From | Paul Burton <> | Subject | Re: [PATCH 1/4] MIPS: Fix ISA I FP sigcontext access violation handling | Date | Tue, 1 Nov 2016 09:27:39 +0000 |
| |
On Monday, 31 October 2016 16:25:44 GMT Maciej W. Rozycki wrote: > Complement commit 0ae8dceaebe3 ("Merge with 2.3.10.") and use the local > `fault' handler to recover from FP sigcontext access violation faults, > like corresponding code does in r4k_fpu.S. The `bad_stack' handler is > in syscall.c and is not suitable here as we want to propagate the error > condition up through the caller rather than killing the thread outright. > > Signed-off-by: Maciej W. Rozycki <macro@imgtec.com> > --- > I guess it hardly ever triggers and code still builds, so it has aged so > well... > > Maciej > > linux-mips-isa1-sig-fp-context-fault.patch > Index: linux-sfr-test/arch/mips/kernel/r2300_fpu.S > =================================================================== > --- linux-sfr-test.orig/arch/mips/kernel/r2300_fpu.S 2016-10-22 > 02:36:46.000000000 +0100 +++ > linux-sfr-test/arch/mips/kernel/r2300_fpu.S 2016-10-22 02:37:20.891186000 > +0100 @@ -21,7 +21,7 @@ > #define EX(a,b) \ > 9: a,##b; \ > .section __ex_table,"a"; \ > - PTR 9b,bad_stack; \ > + PTR 9b,fault; \ > .previous > > .set noreorder
Hi Maciej,
Looks good to me:
Reviewed-by: Paul Burton <paul.burton@imgtec.com>
Thanks, Paul[unhandled content-type:application/pgp-signature] |  |