Messages in this thread Patch in this message |  | | Date | Mon, 10 Oct 2016 10:50:50 +0800 | From | Dave Young <> | Subject | Re: Change CONFIG_DEVKMEM default value to n |
| |
On 10/10/16 at 10:44am, Dave Young wrote: > On 10/07/16 at 05:57am, Greg Kroah-Hartman wrote: > > On Fri, Oct 07, 2016 at 10:04:11AM +0800, Dave Young wrote: > > > Kconfig comment suggests setting it as "n" if in doubt thus move the > > > default value to 'n'. > > > > > > Signed-off-by: Dave Young <dyoung@redhat.com> > > > Suggested-by: Kees Cook <keescook@chromium.org> > > > --- > > > drivers/char/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > --- linux-x86.orig/drivers/char/Kconfig > > > +++ linux-x86/drivers/char/Kconfig > > > @@ -17,7 +17,7 @@ config DEVMEM > > > > > > config DEVKMEM > > > bool "/dev/kmem virtual device support" > > > - default y > > > + default n > > > > If you remove the "default" line, it defaults to 'n'. > > I personally perfer a "default n", but I can update it..
Greg, here is an update with dropping the default line:
Move CONFIG_DEVKMEM default to n
Kconfig comment suggests setting it as "n" if in doubt thus move the default value to 'n'.
Signed-off-by: Dave Young <dyoung@redhat.com> Suggested-by: Kees Cook <keescook@chromium.org> --- drivers/char/Kconfig | 1 - 1 file changed, 1 deletion(-)
--- linux-x86.orig/drivers/char/Kconfig +++ linux-x86/drivers/char/Kconfig @@ -17,7 +17,6 @@ config DEVMEM config DEVKMEM bool "/dev/kmem virtual device support" - default y help Say Y here if you want to support the /dev/kmem device. The /dev/kmem device is rarely used, but can be used for certain
|  |