lkml.org 
[lkml]   [2016]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: pci_alloc_irq_vectors use in 8250_lpss.c
On Mon, Oct 10, 2016 at 1:01 AM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sun, Oct 9, 2016 at 8:56 PM, Christoph Hellwig <hch@lst.de> wrote:
>> Hi Andy,
>>
>> two comment on your ぱatch to add MSI support to the above driver.
>>
>> First pci_alloc_irq_vectors gained a mandatory flags argument, so
>> for MSI suport you now need to pass PCI_IRQ_MSI in flags for the
>> code to work.
>
> I will check this. Thanks for pointing to it.

Yeah, this has to be amended.

>
>>
>> Second please make sure to always pair pci_alloc_irq_vectors
>> with pci_free_irq_vectors on the remove path.
>
> For my opinion it should be done in PCI code since I'm using
> manageable resources. It's already done for all PCI API usually used
> at ->probe().

Nothing is required to do until you don't use some specific code. If
you plan extend *_free_*() function in the future, please, consider
manageable resources and automatic releasing.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2016-10-10 00:21    [W:0.051 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site