[lkml]   [2016]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: pci_alloc_irq_vectors use in 8250_lpss.c
On Sun, Oct 9, 2016 at 8:56 PM, Christoph Hellwig <> wrote:
> Hi Andy,
> two comment on your ぱatch to add MSI support to the above driver.
> First pci_alloc_irq_vectors gained a mandatory flags argument, so
> for MSI suport you now need to pass PCI_IRQ_MSI in flags for the
> code to work.

I will check this. Thanks for pointing to it.

> Second please make sure to always pair pci_alloc_irq_vectors
> with pci_free_irq_vectors on the remove path.

For my opinion it should be done in PCI code since I'm using
manageable resources. It's already done for all PCI API usually used
at ->probe().

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2016-10-10 00:08    [W:0.040 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site