[lkml]   [2016]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 04/18] x86/intel_rdt: Feature discovery
On Sat, Oct 08, 2016 at 01:54:54PM -0700, Fenghua Yu wrote:
> > I think these #defines are specific to Intel. I would prefer if we
> > have _INTEL_ somewhere in them.

We don't generally add vendor names to those defines. Even more so if
the 0x0... leaf range is Intel-specific anyway.

> Is adding "Intel" in comment good?

I don't see any need if the leaf has already this heading:

/* Intel-defined CPU features, CPUID level 0x00000007:0 (ebx), word 9 */


SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

 \ /
  Last update: 2016-10-08 21:53    [W:0.167 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site