[lkml]   [2016]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during idle state
On Sat, Oct 08, 2016 at 07:00:06PM +0300, Jarkko Sakkinen wrote:

> Rather you it would be better not to use cmdReady/goIdle at all if
> kernel is not compiled with CONFIG_PM.

It would be best practice to ensure the tpm is powered up no matter
how the kernel is compiled.. The firmware may have left it in idle or

FWIW, I broadly agree there is no need to put the device into idle on
the error paths. It probably wasn't idle when the driver attached to


 \ /
  Last update: 2016-10-08 18:43    [W:0.054 / U:1.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site