Messages in this thread |  | | Date | Wed, 5 Oct 2016 22:53:36 +0100 | From | Chris Wilson <> | Subject | Re: [Intel-gfx] [PATCH 5/6] drm/i915/gen9: Get rid of redundant watermark values |
| |
On Wed, Oct 05, 2016 at 06:44:04PM -0300, Paulo Zanoni wrote: > Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu: > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index dd15ae2..c580d3d 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -3378,6 +3378,8 @@ static void skylake_update_primary_plane(struct > > drm_plane *plane, > > struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state- > > >base.crtc); > > struct drm_framebuffer *fb = plane_state->base.fb; > > const struct skl_wm_values *wm = &dev_priv->wm.skl_results; > > + const struct skl_plane_wm *p_wm = > > + &crtc_state->wm.skl.optimal.planes[0]; > > I wish someone would do a patch to convert all these hardcoded values > to PLANE_X, and convert "int"s to "enum plane"s everywhere.
Note that this is not PLANE_A, but setting up a shorthand local for
const struct skl_plane_wm *p_wm = crtc_state->wm.skl.optimal.planes;
-Chris
-- Chris Wilson, Intel Open Source Technology Centre
|  |