Messages in this thread |  | | Date | Tue, 4 Oct 2016 18:15:49 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH 06/14] ASoC: Add sun8i digital audio codec |
| |
Hi,
> +static const struct of_device_id sun8i_codec_of_match[] = { > + { .compatible = "allwinner,sun8i-a33-codec" }, > + { .compatible = "allwinner,sun8i-a23-codec" },
I thought that the A23 and A33 had different codecs? In that case, it wouldn't be a good assumption to make
> + {} > +}; > +MODULE_DEVICE_TABLE(of, sun8i_codec_of_match); > + > +static struct platform_driver sun8i_codec_driver = { > + .driver = { > + .name = "sun8i-codec", > + .owner = THIS_MODULE, > + .of_match_table = sun8i_codec_of_match, > + }, > + .probe = sun8i_codec_probe, > + .remove = sun8i_codec_remove, > +}; > +module_platform_driver(sun8i_codec_driver); > + > +MODULE_DESCRIPTION("Allwinner A33 (sun8i) codec driver"); > +MODULE_AUTHOR("huanxin<huanxin@reuuimllatech.com>");
Those obfuscated email adresses are not really helpful :)
Thanks, Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] |  |