[lkml]   [2016]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Fix suspicious RCU usage in nfs_idmap_get_key.
Artem Savkov <> wrote:

> nfs_idmap_get_key doesn't hold rkey->sem when calling user_key_payload
> resulting in a "suspicious RCU usage" lockdep splat. It does, however hold
> rcu_read_lock, so it either needs to use unprotected rcu_dereference, or take
> rkey->sem instead of rcu_read_lock.

This shouldn't be using rkey->sem. user_key_payload() should do sufficient
RCU magic that rcu_read_lock() is sufficient. Can you please include the RCU
splat? It's possible user_key_payload() is wrong.


 \ /
  Last update: 2016-10-04 17:45    [W:0.084 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site