lkml.org 
[lkml]   [2016]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: hns: qdd missing \n to end of dev_err messages
From
Date
Hello.

On 10/04/2016 02:06 PM, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, dev_err messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> index a834774..7aeed08 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> @@ -547,7 +547,7 @@ int hns_mac_set_autoneg(struct hns_mac_cb *mac_cb, u8 enable)
> struct mac_driver *mac_ctrl_drv = hns_mac_get_drv(mac_cb);
>
> if (mac_cb->phy_if == PHY_INTERFACE_MODE_XGMII && enable) {
> - dev_err(mac_cb->dev, "enable autoneg is not allowed!");
> + dev_err(mac_cb->dev, "enable autoneg is not allowed!\n");

Enabling, perhaps?

> return -ENOTSUPP;
> }
>
> @@ -571,7 +571,7 @@ int hns_mac_set_pauseparam(struct hns_mac_cb *mac_cb, u32 rx_en, u32 tx_en)
>
> if (mac_cb->mac_type == HNAE_PORT_DEBUG) {
> if (is_ver1 && (tx_en || rx_en)) {
> - dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!");
> + dev_err(mac_cb->dev, "macv1 cann't enable tx/rx_pause!\n");

Perhaps a good time to fix this "cann't"?

[...]

MBR, Sergei

\
 
 \ /
  Last update: 2016-10-04 14:33    [W:0.053 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site