lkml.org 
[lkml]   [2016]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: Device or HBA level QD throttling creates randomness in sequetial workload
From
Date
Hi,

One guess would be that this isn't around a requeue condition, but
rather the fact that we don't really guarantee any sort of hard FIFO
behavior between the software queues. Can you try this test patch to see
if it changes the behavior for you? Warning: untested...

diff --git a/block/blk-mq.c b/block/blk-mq.c
index f3d27a6dee09..5404ca9c71b2 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -772,6 +772,14 @@ static inline unsigned int queued_to_index(unsigned
int queued)
return min(BLK_MQ_MAX_DISPATCH_ORDER - 1, ilog2(queued) + 1);
}

+static int rq_pos_cmp(void *priv, struct list_head *a, struct list_head *b)
+{
+ struct request *rqa = container_of(a, struct request, queuelist);
+ struct request *rqb = container_of(b, struct request, queuelist);
+
+ return blk_rq_pos(rqa) < blk_rq_pos(rqb);
+}
+
/*
* Run this hardware queue, pulling any software queues mapped to it in.
* Note that this function currently has various problems around ordering
@@ -812,6 +820,14 @@ static void __blk_mq_run_hw_queue(struct
blk_mq_hw_ctx *hctx)
}

/*
+ * If the device is rotational, sort the list sanely to avoid
+ * unecessary seeks. The software queues are roughly FIFO, but
+ * only roughly, there are no hard guarantees.
+ */
+ if (!blk_queue_nonrot(q))
+ list_sort(NULL, &rq_list, rq_pos_cmp);
+
+ /*
* Start off with dptr being NULL, so we start the first request
* immediately, even if we have more pending.
*/
--
Jens Axboe

\
 
 \ /
  Last update: 2016-10-31 18:24    [W:0.079 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site