lkml.org 
[lkml]   [2016]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v10 10/19] vfio iommu: Add blocking notifier to notify DMA_UNMAP
From
Date


On 10/31/2016 9:20 AM, Jike Song wrote:
> On 10/27/2016 05:29 AM, Kirti Wankhede wrote:
>> Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers
>> about DMA_UNMAP.
>> Exported two APIs vfio_register_notifier() and vfio_unregister_notifier().
>> Vendor driver should register notifer using these APIs.
>> Vendor driver should use VFIO_IOMMU_NOTIFY_DMA_UNMAP action to invalidate
>> mappings.
>>
>> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
>> Signed-off-by: Neo Jia <cjia@nvidia.com>
>> Change-Id: I5910d0024d6be87f3e8d3e0ca0eaeaaa0b17f271
>> ---
>> drivers/vfio/vfio.c | 73 +++++++++++++++++++++++++++++++++
>> drivers/vfio/vfio_iommu_type1.c | 89 ++++++++++++++++++++++++++++++++++++-----
>> include/linux/vfio.h | 11 +++++
>> 3 files changed, 163 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
>> index 28b50ca14c52..ff05ac6b1e90 100644
>> --- a/drivers/vfio/vfio.c
>> +++ b/drivers/vfio/vfio.c
>> @@ -1891,6 +1891,79 @@ err_unpin_pages:
>> }
>> EXPORT_SYMBOL(vfio_unpin_pages);
>>
>> +int vfio_register_notifier(struct device *dev, struct notifier_block *nb)
>> +{
>
> Hi Kirti,
>
> Given that below 4 methods are members of vfio_iommu_driver_ops:
>
> pin_pages
> unpin_pages
> register_notifier
> unregister_notifier
>
> the names of exposed VFIO APIs could possibly be clearer:
>
> vfio_iommu_pin_pages
> vfio_iommu_unpin_pages
> vfio_iommu_register_notifier
> vfio_iommu_unreigster_nodier
>

Hey Jike,

I had followed the same style as other members in this structure:

attach_group
detach_group

Thanks,
Kirti

\
 
 \ /
  Last update: 2016-10-31 07:01    [W:0.074 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site