lkml.org 
[lkml]   [2016]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] cxl: Fix error handling
Date
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:

> On 31/10/16 08:34, Christophe JAILLET wrote:
>> 'cxl_dev_context_init()' returns an error pointer in case of error, not
>> NULL. So test it with IS_ERR.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>
>> ---
>> un-compiled because I don't have the required cross build environment.
>
> Builds fine here.
>
> In future, you might want to bundle all 3 of your patches either into 1
> patch (while they are changes which can be done separately, it's all
> fixes to one type of problem in relation to one function, so personally
> I'm okay with that) or send it as a series, so that it's clear to
> everyone that they're all related fixes.

> Additionally, having the same patch subject line for two patches sent in
> short succession is a bit confusing - in future, try and avoid that.

Yeah. I actually assumed it was two versions of the same patch.

cheers

\
 
 \ /
  Last update: 2016-10-31 10:51    [W:0.098 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site