Messages in this thread |  | | Date | Sun, 30 Oct 2016 14:43:08 +0100 | From | Martin Schwidefsky <> | Subject | Re: [PATCH 3/3] s390: char: make slp_ctl explicitly non-modular |
| |
On Sat, 29 Oct 2016 16:38:43 -0400 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> The Makefile currently controlling compilation of this code is obj-y, > meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular usage, so that when reading > the driver there is no doubt it is builtin-only. > > Since module_misc_device translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com> > Cc: Paul Gortmaker <paul.gortmaker@windriver.com> > Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com> > Cc: linux-s390@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
That idea behind the patch makes sense to me. But the built robot reports a new warning which should be fixed. If that is done:
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
-- blue skies, Martin.
"Reality continues to ruin my life." - Calvin.
|  |