[lkml]   [2016]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 3/3] s390: char: make slp_ctl explicitly non-modular
On Sat, 29 Oct 2016 16:38:43 -0400
Paul Gortmaker <> wrote:

> The Makefile currently controlling compilation of this code is obj-y,
> meaning that it currently is not being built as a module by anyone.
> Lets remove the couple traces of modular usage, so that when reading
> the driver there is no doubt it is builtin-only.
> Since module_misc_device translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> Cc: Martin Schwidefsky <>
> Cc: Heiko Carstens <>
> Cc: Paul Gortmaker <>
> Cc: Michael Holzheu <>
> Cc:
> Signed-off-by: Paul Gortmaker <>

That idea behind the patch makes sense to me. But the built robot
reports a new warning which should be fixed. If that is done:

Acked-by: Martin Schwidefsky <>

blue skies,

"Reality continues to ruin my life." - Calvin.

 \ /
  Last update: 2016-10-30 14:43    [W:0.068 / U:2.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site