[lkml]   [2016]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRFC if==else in i40iw_virtchnl.
Hi Faisal !

your commit 4097351a47c5 ("i40iw: virtual channel handling files")
adds the following lines in i40iw_vchnl_recv_pf()

+ if (vchnl_msg->iw_op_ver != I40IW_VCHNL_OP_GET_VER_V0)
+ vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
+ else
+ vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
+ return I40IW_SUCCESS;

as the if==else here this looks buggy - if it is intended it atleast needs
a comment/explaination but it did not seem to make much sense in this
form (Note this is the only place where vchnl_pf_send_get_ver_resp() is
being called so the intent is not clear from code review and thus no patch
can be resonably suggested.


 \ /
  Last update: 2016-10-30 13:34    [W:0.024 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site