Messages in this thread |  | | From | Paul Gortmaker <> | Subject | [PATCH 0/9] s390: remove modular usage from non-modular code | Date | Sun, 30 Oct 2016 16:37:23 -0400 |
| |
My ongoing audit looking for non-modular code that needlessly uses modular macros (vs. built-in equivalents) and/or has dead code relating to module unloading that can never be executed led to the creation of these s390 related commits.
For anyone new to the underlying goal of this cleanup, we are trying to not use module support for code that can never be built as a module since:
(1) it is easy to accidentally write unused module_exit and remove code (2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it (3) it requires the include of the module.h header file which in turn includes nearly everything else, thus adding to CPP overhead. (4) it gets copied/replicated into other code and spreads like weeds.
Build tested on current linux-next (allyes/allno/allmod) to ensure no silly typos or implicit include issues that would break compilation crept in.
---
Cc: Arnd Bergmann <arndb@de.ibm.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Christian Borntraeger <borntraeger@de.ibm.com> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: linux-s390@vger.kernel.org Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Peter Oberparleiter <oberpar@linux.vnet.ibm.com> Cc: Sebastian Ott <sebott@linux.vnet.ibm.com>
Paul Gortmaker (9): s390: cio: make it explicitly non-modular s390: char: make zcore explicitly non-modular s390: char: make con3215 explicitly non-modular s390: char: make sclp_tty explicitly non-modular s390: char: make slcp_quiesce explicitly non-modular s390: hotplug: make pci_hpc explicitly non-modular s390: hypfs: make inode explicitly non-modular s390: kernel: make lgr explicitly non-modular s390: virtio: make ccw explicitly non-modular
arch/s390/hypfs/inode.c | 24 ++++-------------------- arch/s390/kernel/lgr.c | 5 +++-- drivers/pci/hotplug/s390_pci_hpc.c | 7 ++----- drivers/s390/char/con3215.c | 12 +----------- drivers/s390/char/sclp_quiesce.c | 4 +--- drivers/s390/char/sclp_tty.c | 3 +-- drivers/s390/char/zcore.c | 20 +------------------- drivers/s390/cio/cmf.c | 10 ++-------- drivers/s390/cio/css.c | 6 +++--- drivers/s390/cio/device.c | 6 +++--- drivers/s390/cio/device_ops.c | 5 +++-- drivers/s390/virtio/virtio_ccw.c | 25 ++----------------------- 12 files changed, 26 insertions(+), 101 deletions(-)
-- 2.10.1
|  |