Messages in this thread |  | | From | Linus Walleij <> | Date | Tue, 4 Oct 2016 00:27:01 +0200 | Subject | Re: [PATCH] bus: qcom-ebi2: make it explicitly non-modular |
| |
On Tue, Sep 27, 2016 at 3:20 AM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> The Kconfig currently controlling compilation of this code is: > > drivers/bus/Kconfig:config QCOM_EBI2 > drivers/bus/Kconfig: bool "Qualcomm External Bus Interface 2 (EBI2)" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular infrastructure use, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > We don't replace module.h with init.h since the file already has that. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
I was asked during review to make it a module, from originally being a bool.
Just missed to update Kconfig as it seems :(
So the right patch is a oneliner making it tristate.
Yours, Linus Walleij
|  |