[lkml]   [2016]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] bus: qcom-ebi2: make it explicitly non-modular
On Tue, Sep 27, 2016 at 3:20 AM, Paul Gortmaker
<> wrote:

> The Kconfig currently controlling compilation of this code is:
> drivers/bus/Kconfig:config QCOM_EBI2
> drivers/bus/Kconfig: bool "Qualcomm External Bus Interface 2 (EBI2)"
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> We don't replace module.h with init.h since the file already has that.
> Cc: Linus Walleij <>
> Signed-off-by: Paul Gortmaker <>

I was asked during review to make it a module, from originally
being a bool.

Just missed to update Kconfig as it seems :(

So the right patch is a oneliner making it tristate.

Linus Walleij

 \ /
  Last update: 2016-10-04 00:27    [W:0.092 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site