lkml.org 
[lkml]   [2016]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [media] : Removing warnings caught by checkpatch.pl
On Sun, Oct 02, 2016 at 02:30:45AM +0530, Harman Kalra wrote:
> static int iss_video_queue_setup(struct vb2_queue *vq,
> - unsigned int *count, unsigned int *num_planes,
> - unsigned int sizes[], struct device *alloc_devs[])
> + unsigned int *count, unsigned int *num_planes,
> + unsigned int sizes[], struct device *alloc_devs[])

2 spaces + 3 tabs -> 2 spaces + 2 tabs? Am I seeing this correctly?
Both ways are against CodingStyle.

> - /* Try the get selection operation first and fallback to get format if not
> - * implemented.
> + /* Try the get selection operation first and
> + * fallback to get format if not implemented.
> */

This comment style is discouraged so this is at lease not perfect.
Doesn't checkpatch complain with this change? If it doesn't, could you
please also check with --strict, as long as you're working on style.

\
 
 \ /
  Last update: 2016-10-03 23:54    [W:0.100 / U:1.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site