Messages in this thread |  | | Subject | Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c | From | Sergio Paracuellos <> | Date | Mon, 3 Oct 2016 20:12:09 +0200 |
| |
El 2016年10月03日 a las 18:16, Joe Perches escribió: > On Mon, 2016-10-03 at 18:04 +0200, Sergio Paracuellos wrote: >> This patch fix the following checkpatch.pl warnings in prism2sta.c: >> WARNING: line over 80 characters > [] >> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c > [] >> @@ -1099,7 +1101,8 @@ static void prism2sta_inf_hostscanresults(struct wlandevice *wlandev, >> >> kfree(hw->scanresults); >> >> - hw->scanresults = kmemdup(inf, sizeof(struct hfa384x_InfFrame), GFP_ATOMIC); >> + hw->scanresults = kmemdup(inf, >> + sizeof(struct hfa384x_InfFrame), GFP_ATOMIC); > > Perhaps better as > > hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC); >
I agree. But because all the code is full of sizeof(struct xxx) I though it would be better to follow the actual style and not change only one...
I don't have any problem in fix this patch and resend it. What should I do?
Cheers, Sergio Paracuellos
|  |