lkml.org 
[lkml]   [2016]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] pinctrl: max77620: add OF dependency
On Fri, Oct 28, 2016 at 10:19 AM, Arnd Bergmann <arnd@arndb.de> wrote:

> Drivers using pinconf_generic_params tables cannot be built with
> CONFIG_OF disabled:
>
> drivers/pinctrl/pinctrl-max77620.c:53:44: error: array type has incomplete element type ‘struct pinconf_generic_params’
> drivers/pinctrl/pinctrl-max77620.c:55:3: error: field name not in record or union initializer
> drivers/pinctrl/pinctrl-max77620.c:55:3: note: (near initialization for ‘max77620_cfg_params’)
> drivers/pinctrl/pinctrl-max77620.c:56:3: error: field name not in record or union initializer
>
> This adds a dependency for max77620 to disallow that configuration.
>
> Alternatively, we could rework the pinctrl infrastructure to make the
> configuration valid for compile-testing.
>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Fixes: 453943dc8f45 ("mfd: Enable compile testing for max77620 and max77686")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2016-10-29 10:31    [W:0.074 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site