lkml.org 
[lkml]   [2016]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/15] thermal: int340x_thermal: use permission-specific DEVICE_ATTR variants
    Date
    Use DEVICE_ATTR_RW for read-write attributes.  This simplifies the
    source code, improves readbility, and reduces the chance of
    inconsistencies.

    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @rw@
    declarer name DEVICE_ATTR;
    identifier x,x_show,x_store;
    @@

    DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);

    @script:ocaml@
    x << rw.x;
    x_show << rw.x_show;
    x_store << rw.x_store;
    @@

    if not (x^"_show" = x_show && x^"_store" = x_store)
    then Coccilib.include_match false

    @@
    declarer name DEVICE_ATTR_RW;
    identifier rw.x,rw.x_show,rw.x_store;
    @@

    - DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);
    + DEVICE_ATTR_RW(x);
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/thermal/int340x_thermal/int3400_thermal.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/thermal/int340x_thermal/int3400_thermal.c b/drivers/thermal/int340x_thermal/int3400_thermal.c
    index 5836e55..9413c4a 100644
    --- a/drivers/thermal/int340x_thermal/int3400_thermal.c
    +++ b/drivers/thermal/int340x_thermal/int3400_thermal.c
    @@ -96,7 +96,7 @@ static ssize_t current_uuid_store(struct device *dev,
    return -EINVAL;
    }

    -static DEVICE_ATTR(current_uuid, 0644, current_uuid_show, current_uuid_store);
    +static DEVICE_ATTR_RW(current_uuid);
    static DEVICE_ATTR_RO(available_uuids);
    static struct attribute *uuid_attrs[] = {
    &dev_attr_available_uuids.attr,
    \
     
     \ /
      Last update: 2016-10-29 22:00    [W:6.834 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site