[lkml]   [2016]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 4.4 46/51] perf hists browser: Fix event group display
    4.4-stable review patch.  If anyone has any objections, please let me know.


    From: Namhyung Kim <>

    commit d9ea48bc4e7cc297ca1073fa3f90ed80d964b7b4 upstream.

    Milian reported that the event group on TUI shows duplicated overhead.
    This was due to a bug on calculating hpp->buf position. The
    hpp_advance() was called from __hpp__slsmg_color_printf() on TUI but
    it's already called from the hpp__call_print_fn macro in __hpp__fmt().
    The end result is that the print function returns number of bytes it
    printed but the buffer advanced twice of the length.

    This is generally not a problem since it doesn't need to access the
    buffer again. But with event group, overhead needs to be printed
    multiple times and hist_entry__snprintf_alignment() tries to fill the
    space with buffer after it printed. So it (brokenly) showed the last
    overhead again.

    The bug was there from the beginning, but I think it's only revealed
    when the alignment function was added.

    Reported-by: Milian Wolff <>
    Signed-off-by: Namhyung Kim <>
    Cc: Andi Kleen <>
    Cc: Jiri Olsa <>
    Cc: Peter Zijlstra <>
    Fixes: 89fee7094323 ("perf hists: Do column alignment on the format iterator")
    Signed-off-by: Arnaldo Carvalho de Melo <>
    Signed-off-by: Greg Kroah-Hartman <>

    tools/perf/ui/browsers/hists.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/tools/perf/ui/browsers/hists.c
    +++ b/tools/perf/ui/browsers/hists.c
    @@ -684,7 +684,6 @@ static int __hpp__slsmg_color_printf(str
    ret = scnprintf(hpp->buf, hpp->size, fmt, len, percent);
    ui_browser__printf(arg->b, "%s", hpp->buf);

    - advance_hpp(hpp, ret);
    return ret;

     \ /
      Last update: 2016-10-29 15:51    [W:3.520 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site