Messages in this thread |  | | Date | Sat, 22 Oct 2016 18:37:35 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] acpi/apei: Fix in-correct return value |
| |
On Fri, Oct 21, 2016 at 11:28:29PM +0200, Rafael J. Wysocki wrote: > Boris, all fine here?
Short answer: Yeah, looks ok to me.
Longer answer: I mean, this way ghes_proc() *actually* propagates the return value of ghes_read_estatus() and we don't do any processing if it failed.
Which doesn't really tell me a whole lot about the actual processing, i.e., what ghes_do_proc() did.
But ghes_do_proc() doesn't return anything and ghes_proc()'s retval is used only in contexts where we're asking whether something got processed or not.
And for that, that fix is adequate. So:
Reviewed-by: Borislav Petkov <bp@suse.de>
-- Regards/Gruss, Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --
|  |