lkml.org 
[lkml]   [2016]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] i2c: i2c-piix4: several coding style fixes
From
Date
On 14-10-2016 08:08, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Oct 13, 2016 at 11:39:01PM +0100, Carlos Palminha wrote:
>> @@ -196,7 +204,7 @@ static int piix4_setup(struct pci_dev *PIIX4_dev,
>> } else {
>> pci_read_config_word(PIIX4_dev, SMBBA, &piix4_smba);
>> piix4_smba &= 0xfff0;
>> - if(piix4_smba == 0) {
>> + if (piix4_smba == 0) {
>> dev_err(&PIIX4_dev->dev, "SMBus base address "
>> "uninitialized - upgrade BIOS or use "
>> "force_addr=0xaddr\n");
>
> did you left this message in three lines on purpose?
>
Hi Uwe,

There were some missing lines. I had some doubts regarding if the
"quoted string" could go with more than 80 chars. I see now that
checkpatch is ok.

I'll resend a v3.

> Best regards
> Uwe
>

Regards,
C.Palminha

\
 
 \ /
  Last update: 2016-10-14 13:57    [W:0.071 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site