Messages in this thread |  | | Subject | Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7) | From | Johannes Berg <> | Date | Fri, 14 Oct 2016 12:00:12 +0200 |
| |
> So why is the performance hit acceptable for ESP but not for WPA? We > could easily implement the same thing, i.e., > kmalloc(GFP_ATOMIC)/kfree the aead_req struct rather than allocate it > on the stack
Yeah, maybe we should. It's likely a much bigger allocation, but I don't actually know if that affects speed.
In most cases where you want high performance we never hit this anyway since we'll have hardware crypto. I know for our (Intel's) devices we normally never hit these code paths.
But on the other hand, you also did your changes for a reason, and the only reason I can see of that is performance. So you'd be the one with most "skin in the game", I guess?
johannes
|  |