lkml.org 
[lkml]   [2016]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf annotate: Cleanup arch specific stuff
From
Date


On Monday 10 October 2016 10:09 PM, Naveen N. Rao wrote:
> On 2016/10/10 01:24PM, Arnaldo Carvalho de Melo wrote:
>> Em Mon, Oct 10, 2016 at 07:29:02PM +0530, Ravi Bangoria escreveu:
>>> Move arch specific stuff from util/annotate.c to their respective
>>> files in util/annotate directory.
>>>
>>> No functionality changes.
>>>
>>> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
>>> ---
>>> tools/perf/util/Build | 1 +
>>> tools/perf/util/annotate.c | 259 +++----------------------------------
>>> tools/perf/util/annotate.h | 23 ++++
>>> tools/perf/util/annotate/Build | 3 +
>>> tools/perf/util/annotate/arm.c | 50 +++++++
>>> tools/perf/util/annotate/powerpc.c | 63 +++++++++
>>> tools/perf/util/annotate/x86.c | 107 +++++++++++++++
>> We already have a per arch area: tools/perf/arch/
> I think this was done to support cross-arch annotate similar to the
> remote unwind support with util/libunwind/

Yes, because tools/perf/arch/ will only include host arch code.

-Ravi

> - Naveen
>

\
 
 \ /
  Last update: 2016-10-10 22:25    [W:0.075 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site