Messages in this thread |  | | From | Jes Sorensen <> | Subject | Re: md/raid1: Improve another size determination in setup_conf() | Date | Mon, 10 Oct 2016 09:11:25 -0400 |
| |
SF Markus Elfring <elfring@users.sourceforge.net> writes: >>>> but patches that just fix coding style are a bad thing >>> >>> When you find such a change opportunity so "bad", are there any >>> circumstances left over where you would dare to touch the corresponding >>> source code line. >> >> If you actually rewrite the code or fix some real bug there. > > Do the proposed update steps 12 - 16 for the function "setup_conf" > (in this software module) fit to your condition? > > Do you reject this update step?
I do - those changes do nothing to improve the code and simply hides a lot of history.
Jes
|  |