[lkml]   [2016]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: md/raid1: Improve another size determination in setup_conf()
SF Markus Elfring <> writes:
>>>> but patches that just fix coding style are a bad thing
>>> When you find such a change opportunity so "bad", are there any
>>> circumstances left over where you would dare to touch the corresponding
>>> source code line.
>> If you actually rewrite the code or fix some real bug there.
> Do the proposed update steps 12 - 16 for the function "setup_conf"
> (in this software module) fit to your condition?
> Do you reject this update step?

I do - those changes do nothing to improve the code and simply hides a
lot of history.


 \ /
  Last update: 2016-10-10 15:12    [W:0.812 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site