lkml.org 
[lkml]   [2016]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 04/15] md-cluster: Improve another size determination in __sendmsg()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 1 Oct 2016 12:21:48 +0200

    Replace the specification of a data structure by a pointer dereference
    as the parameter for the operator "sizeof" to make the corresponding size
    determination a bit safer according to the Linux coding style convention.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/md/md-cluster.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
    index 7af27dd..c81eed4 100644
    --- a/drivers/md/md-cluster.c
    +++ b/drivers/md/md-cluster.c
    @@ -706,7 +706,7 @@ static int __sendmsg(struct md_cluster_info *cinfo, struct cluster_msg *cmsg)
    }

    memcpy(cinfo->message_lockres->lksb.sb_lvbptr, (void *)cmsg,
    - sizeof(struct cluster_msg));
    + sizeof(*cmsg));
    /*down-convert EX to CW on Message*/
    error = dlm_lock_sync(cinfo->message_lockres, DLM_LOCK_CW);
    if (error) {
    --
    2.10.0
    \
     
     \ /
      Last update: 2016-10-01 16:49    [W:4.025 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site