Messages in this thread |  | | Date | Sat, 1 Oct 2016 11:47:11 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF |
| |
On Wed, Sep 28, 2016 at 10:12:41PM -0400, Sinan Kaya wrote: > Configure the DMA bindings for the device tree based firmware. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > --- > drivers/dma/qcom/hidma_mgmt.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c > index 82f36e4..e8f6b84 100644 > --- a/drivers/dma/qcom/hidma_mgmt.c > +++ b/drivers/dma/qcom/hidma_mgmt.c > @@ -375,8 +375,11 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np) > ret = PTR_ERR(new_pdev); > goto out; > } > + of_node_get(child); > + new_pdev->dev.of_node = child; > of_dma_configure(&new_pdev->dev, child); > - > + of_msi_configure(&new_pdev->dev, child); > + of_node_put(child);
should this be done unconditionally? Dont we needto call this only for platforms with msi?
> kfree(res); > res = NULL; > } > -- > 1.9.1 >
-- ~Vinod
|  |