Messages in this thread |  | | Date | Sat, 1 Oct 2016 22:22:07 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH 2/2] tpm: replace dynamically allocated bios_dir with a static array |
| |
On Sat, Oct 01, 2016 at 10:49:32AM -0600, Jason Gunthorpe wrote: > On Sat, Oct 01, 2016 at 03:41:17PM +0300, Jarkko Sakkinen wrote: > > - bin_file = > > + chip->bios_dir[cnt] = > > securityfs_create_file("binary_bios_measurements", > > - S_IRUSR | S_IRGRP, tpm_dir, > > + S_IRUSR | S_IRGRP, chip->bios_dir[cnt], > > That is certainly not right, Nayna's version was correct, the function > argument is the directory to create under and bios_dir[0] is setup as the > directory for tpm. This is also why removal is done in reverse order, > files are removed then the directory that contains them.
Right. I overlooked this.
> Jason
/Jarkko
|  |