lkml.org 
[lkml]   [2016]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: weird DirectMap2M accounting.
On Wed, Jan 06, 2016 at 07:11:41PM -0500, Dave Jones wrote:
> On Wed, Jan 06, 2016 at 06:55:27PM -0500, Dave Jones wrote:
> > I just spotted this in /proc/meminfo on an old Core2 machine with 4G.
> >
> > DirectMap2M: 18446744073709543424 kB
> >
> > Looks like we subtracted 8192 from 0 somewhere.
> >
> > Should split_page_count() be checking that direct_pages_count > 0 ?
>
> Ok, this diff makes that number print out as 0.
>
> If this looks ok, I'll submit it properly, though I'd like to better
> understand what's happening here. Shouldn't I have 2M pages ?

Ah. We disable them when compiling with DEBUG_PAGEALLOC.
So this is only needed in that case.
If people think it's worth an ifdef for those two added lines I'll add it,
but it seems pretty benign to just always check.

thoughts?

Dave



\
 
 \ /
  Last update: 2016-01-07 02:01    [W:0.041 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site