lkml.org 
[lkml]   [2016]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes
Hi Pali,

On Tue, 19 Jan 2016 09:36:33 +0100, Pali Rohár wrote:
> On Tuesday 19 January 2016 08:54:26 Jean Delvare wrote:
> > > @@ -978,11 +978,11 @@ int dmi_walk(void (*decode)(const struct dmi_header *, void *),
> > > u8 *buf;
> > >
> > > if (!dmi_available)
> > > - return -1;
> > > + return -ENOENT;
> >
> > -ENOSYS would seem more appropriate?
>
> IIRC -ENOSYS is for non implemented syscalls.

I can see a lot of -ENOSYS in include/linux/*.h returned by stubs when
a specific subsystem is not included. Not related to syscalls at all.
This is what lead to my suggestion.

--
Jean Delvare
SUSE L3 Support

\
 
 \ /
  Last update: 2016-01-19 10:41    [W:0.058 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site