lkml.org 
[lkml]   [2016]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/3] 8250: Split Fintek PCIE to UART to independent file
    From
    Date
    On Tue, 2016-01-19 at 12:33 +0000, One Thousand Gnomes wrote:
    > > The architecture of 8250_pci.c is good for PCIE device with 8250
    > > compatible serial ports. We want to implement all functions of
    > > F81504/508/512, but it'll make 8250_pci.c bloated and complex if we
    > > implement GPIOLIB in 8250_pci.c
    >
    > Your device is multi-function. Create an MFD driver for it. Make the
    > 8250 driver bind to the MFD, and provide your own baud rate methods
    > within the standard 8250 layer

    Ouch, somehow I missed this one!

    Peter, Alan's suggestion is really worth to try.

    >
    > Implement the GPIO lines in a GPIO driver that also binds to the MFD
    > and
    > lives in drivers/gpio
    >
    > All the needed pieces already exist to implement it cleanly this way
    > without duplicating a ton of code.
    >
    > Alan

    --
    Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Intel Finland Oy


    \
     
     \ /
      Last update: 2016-01-19 15:01    [W:8.853 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site