lkml.org 
[lkml]   [2016]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers:pci Add pcie/Kconfig to pci/Kconfig
Hi Bogicevic,

On Tue, Jan 12, 2016 at 06:22:25AM -0800, Bogicevic Sasa wrote:
> Architectures currently have to include both
> drivers/pci/Kconfig and drivers/pci/pcie/Kconfig.
> They should include only drivers/pci/Kconfig, and
> that should handle PCIe as well.
>
> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> ---
> drivers/pci/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 73de4ef..005dd7d 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -119,3 +119,5 @@ config PCI_LABEL
> select NLS
>
> source "drivers/pci/host/Kconfig"
> +
> +source "drivers/pci/pcie/Kconfig"

This project is something I'd like to get done, but it requires a
little more work. If it were this simple, I would have done it long
ago :)

For one thing, we need to update all the Kconfig files that already
include drivers/pci/pcie/Kconfig at the same time. On x86,
arch/x86/Kconfig already includes both:

source "drivers/pci/pcie/Kconfig"
source "drivers/pci/Kconfig"

With your patch applied, I see these new warnings:

05:42:09 ~/linux (wip/bogicevic-kconfig)$ make menuconfig
...
scripts/kconfig/mconf Kconfig
drivers/pci/pcie/Kconfig:61:warning: choice value used outside its choice group
drivers/pci/pcie/Kconfig:67:warning: choice value used outside its choice group
drivers/pci/pcie/Kconfig:74:warning: choice value used outside its choice group

I see that you did verify that removing the source line from
arch/x86/Kconfig does the right thing. We need to put all the related
changes in a single patch so it is self-contained. The tree should be
buildable and functional at every stage.

Bjorn

\
 
 \ /
  Last update: 2016-01-19 04:41    [W:0.077 / U:4.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site