lkml.org 
[lkml]   [2016]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] clk: s2mps11: allocate only one structure for clock init
From
>>
>> IMHO, with all these modifications, it will leave driver with some extra
>> checks and reduced readability, perhaps will make it complex to add
>> support for similar clocks but with different clk_ops, if next version or
>> any similar mfd chip comes up in future.
>
> There is no evidence that some future chip will require clk_ops. All of
> them are so far exactly the same. Even the newly added S2MPS15 is the same.
>

Can we guaranty about future chips?
Even we didn't expect there will be one less clock in case of s2mps14.

> This really should be simplified.
>

IMO, it is just reduction of LoC.

Regards,
Yadwinder

\
 
 \ /
  Last update: 2016-01-19 02:21    [W:0.071 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site