lkml.org 
[lkml]   [2016]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)


On Mon, 18 Jan 2016, Daniel Vetter wrote:

> On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
> > List_for_each entry binds its first argument to an offset from the list
> > pointer, so this should not be NULL.
> >
> > Generated by: scripts/coccinelle/iterators/itnull.cocci
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> >
> > Please take the patch only if it's a positive warning. Thanks!
>
> Against which tree is this? I can't find this anywhere like that ...

I don't know. It may be against a submitted patch.

In case it turns out to be useful, I forgot:

Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>


> -Daniel
>
> >
> > intel_display.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d
> > struct intel_flip_work *work;
> >
> > list_for_each_entry(work, &crtc->flip_work, head) {
> > - if (work && work->event &&
> > + if (work->event &&
> > work->event->base.file_priv == file) {
> > kfree(work->event);
> > work->event = NULL;
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>

\
 
 \ /
  Last update: 2016-01-18 22:01    [W:0.065 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site