lkml.org 
[lkml]   [2016]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv2 1/2] usb: gadget: f_midi: use flexible array member for gmidi_in_port elements
Date
> On 09/01/16 03:47, Michal Nazarewicz wrote:
>> @@ -55,7 +55,6 @@ static const char f_midi_longname[] = "MIDI Gadget";
>> * USB <- IN endpoint <- rawmidi
>> */
>> struct gmidi_in_port {
>> - struct f_midi *midi;

On Wed, Jan 13 2016, Felipe Ferreri Tonello wrote:
> This change is unrelated. I sent a patch removing this pointer as well.

Has it been merged yet? Which branch? Could you point me to the patch?

>> int active;
>> uint8_t cable;
>> uint8_t state;
>> @@ -1115,26 +1112,16 @@ static struct usb_function *f_midi_alloc(struct usb_function_instance *fi)
>> }
>>
>> /* allocate and initialize one new instance */
>> - midi = kzalloc(sizeof(*midi), GFP_KERNEL);
>> + midi = kzalloc(
>> + sizeof(*midi) + opts->in_ports * sizeof(*midi->in_ports_array),
>> + GFP_KERNEL);
>
> Is there a garantee that the compiler will always use in_ports_array at
> the end of the allocated block?

Yep, see <https://en.wikipedia.org/wiki/Flexible_array_member>.

>
>> if (!midi) {
>> mutex_unlock(&opts->lock);
>> return ERR_PTR(-ENOMEM);
>> }
>>
>> - for (i = 0; i < opts->in_ports; i++) {
>> - struct gmidi_in_port *port = kzalloc(sizeof(*port), GFP_KERNEL);
>> -
>> - if (!port) {
>> - status = -ENOMEM;
>> - mutex_unlock(&opts->lock);
>> - goto setup_fail;
>> - }
>> -
>> - port->midi = midi;
>> - port->active = 0;
>> - port->cable = i;
>> - midi->in_port[i] = port;
>> - }
>> + for (i = 0; i < opts->in_ports; i++)
>> + midi->in_ports_array[i].cable = i;
>>
>> /* set up ALSA midi devices */
>> midi->id = kstrdup(opts->id, GFP_KERNEL);

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, ミハウ “mina86” ナザレヴイツ (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--

\
 
 \ /
  Last update: 2016-01-18 17:21    [W:0.038 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site