lkml.org 
[lkml]   [2016]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
On Tue, 12 Jan 2016, Yang, Wenyou wrote:

> Hi Lee,
>
> > -----Original Message-----
> > From: Lee Jones [mailto:lee.jones@linaro.org]
> > Sent: 2016年1月11日 13:49
> > To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> > Cc: Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>;
> > Mark Rutland <mark.rutland@arm.com>; Ian Campbell
> > <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Ferre,
> > Nicolas <Nicolas.FERRE@atmel.com>; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org
> > Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
> >
> > On Fri, 08 Jan 2016, Wenyou Yang wrote:
> >
> > > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two
> > > subdevices:
> > > - Regulator
> > > - Charger
> >
> > Is this really an MFD? What special handling does it require?
>
> Yes, this is an MFD, two sub devices: regulators and charger.
>
> >
> > > This patch adds documentation for ACT8945A DT bindings.
> > >
> > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > > ---
> > >
> > > Documentation/devicetree/bindings/mfd/act8945a.txt | 16
> > ++++++++++++++++
> > > 1 file changed, 16 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > new file mode 100644
> > > index 0000000..406db16
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > @@ -0,0 +1,16 @@
> > > +Device-Tree bindings for Active-semi ACT8945A MFD driver
> > > +
> > > +Required properties:
> > > + - compatible: "active-semi,act8945a".
> > > + - reg: the I2C slave address for the ACT8945A chip
> > > +
> > > +The chip exposes two subdevices:
> > > + - a regulators: see ../regulator/act8945a-regulator.txt
> > > + - a charger: see ../power/act8945a-charger.txt
> > > +
> > > +Example:
> > > + mfd: act8945a@5b {
> >
> > "mfd" is too generic to be a label.
> >
> > Why do you need a label in any case?
>
> Remove the mfd, use act8945a@5b.

Use pmic@5b

> > > + compatible = "active-semi,act8945a";
> > > + reg = <0x5b>;
> > > + status = "okay";
> > > + };
> >
> > This doesn't look much like an MFD to me.
>
> I will add the child nodes for its sub devices, inclusive pmic and charger nodes.

Very well.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2016-01-12 10:41    [W:0.032 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site