lkml.org 
[lkml]   [2016]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: linux-next: strange commit in the parisc-hd tree
From
Date
On Mon, 2016-01-11 at 22:46 +0100, Helge Deller wrote:
> On 10.01.2016 23:28, Stephen Rothwell wrote:
> > I noticed the following commit in the parisc-hd tree today:
> >
> > 43122681dd75 ("Fix __ARCH_SI_PREAMBLE_SIZE on parisc")
> >
> > which among other things says:
> >
> > This patch is not planned to be committed as it currently is.
>
> Right, I split it up into two.
>
> > [...] Please remove it from linux-next inclusion until it is ready.
>
> Sure, I just removed it now.
>
> > Delibeately introducing a patch to linux-next that may well cause build breakage
> > in other architectures just before the merge window opens is a bit antisocial.
>
> That was in no way my intention.
> In contrary, I wanted to see if other platforms are affected by the same bug without knowing.
> Do you by any chance know if it broke some of the existing platforms?
> If yes, that would be valuable info...
>
> Just in case people want to know what this is all about:
> On parisc I found __ARCH_SI_PREAMBLE_SIZE to have a wrong value in 64bit kernel builds.
> Patch which fixes it is here:
> https://patchwork.kernel.org/patch/7994821/
>
> To prevent other (existing and future) architectures to run into the same
> problem I wanted to test this patch via linux-next and inform them:
> http://git.kernel.org/cgit/linux/kernel/git/deller/parisc-linux.git/commit/?h=test__ARCH_SI_PREAMBLE_SIZE

That doesn't fire on powerpc, ie. we have it correct.

Though I wonder why it's not just defined using offsetof? Possibly just that
it's awkward with the way the headers are organised.

cheers

\
 
 \ /
  Last update: 2016-01-12 00:21    [W:1.721 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site