lkml.org 
[lkml]   [2016]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 05/13] tty: serial: 8250: Remove else after return
From
Date
On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> This patch fixes checkpatch warnings about unnecessary else blocks
> after
> return statements.

> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -805,10 +805,10 @@ static int pci_netmos_9900_numports(struct
> pci_dev *dev)
>  
>   pi = (c & 0xff);

And here the parens are redundant.

>  
> - if (pi == 2) {
> + if (pi == 2)
>   return 1;
> - } else if ((pi == 0) &&
> -    (dev->device ==
> PCI_DEVICE_ID_NETMOS_9900)) {
> +
> + if ((pi == 0) && (dev->device == PCI_DEVICE_ID_NETMOS_9900))
> {

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

\
 
 \ /
  Last update: 2016-01-11 14:01    [W:0.131 / U:1.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site